Remove LocalRunCallback import and update callback imports #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the import of LocalRunCallback from the callbacker module and updated dynamic imports in utils.py to only include necessary callbacks.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes import errors when the dashboard package isn’t installed by removing the LocalRunCallback export and only dynamically importing the needed callbacks in utils.py.
- Removed wildcard and unused callback imports in
swanlab/data/utils.py, replacing them with explicit in-function imports. - Updated
swanlab/data/callbacker/__init__.pyto no longer auto-exportLocalRunCallbackand reflect that change in the header.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| swanlab/data/utils.py | Drop from ...callbacker import *; add explicit imports of only DisabledCallback, CloudPyCallback, and OfflineCallback within _create_operator. |
| swanlab/data/callbacker/init.py | Remove LocalRunCallback export; update module doc to note it’s not auto-exported. |
Comments suppressed due to low confidence (2)
swanlab/data/utils.py:165
- The docstring mentions
CloudRunCallback, but the code now imports and usesCloudPyCallback. Update the return description to matchCloudPyCallback.
:return: SwanLabRunOperator, CloudRunCallback
swanlab/data/callbacker/init.py:6
- [nitpick] Since
LocalRunCallbackis no longer auto-exported, consider adding a brief note on how to import it manually if users still need local callbacks (e.g.,from swanlab.data.callbacker.local import LocalRunCallback).
1. local： 本地模式回调器，此回调不自动导出
Feudalman
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the import of LocalRunCallback from the callbacker module and updated dynamic imports in utils.py to only include necessary callbacks.
修复如果 dashboard 没安装时即使没有使用本地模式也报错的问题