refactor: tidy swankit #1111
Merged
refactor: tidy swankit #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase by replacing all references to swankit with swanlab.toolkit and updates the logging/formatting functions to use rich. It prepares for a future merge of swankit code into swanlab by centralizing imports and cleaning up the legacy code.
- Migrated swankit imports to swanlab.toolkit across multiple modules.
- Replaced custom logging formatting with rich’s Text and Status for improved consistency and reliability.
- Updated documentation to reflect the new import paths.
Reviewed Changes
Copilot reviewed 20 out of 52 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| swanlab/data/modules/text/init.py | Updated import from swankit to swanlab.toolkit. |
| swanlab/data/modules/object3d/point_cloud.py | Replaced swankit imports with swanlab.toolkit equivalents. |
| swanlab/data/modules/object3d/object3d.py | Migrated MediaType import to swanlab.toolkit. |
| swanlab/data/modules/object3d/molecule.py | Updated DataSuite, MediaBuffer and MediaType imports. |
| swanlab/data/modules/object3d/model3d.py | Similar migration of imports to swanlab.toolkit. |
| swanlab/data/modules/line/init.py | Reordered and updated import lines to use swanlab.toolkit. |
| swanlab/data/modules/image/init.py | Updated to new import order and references. |
| swanlab/data/modules/custom_charts/init.py | Replaced swankit with swanlab.toolkit in chart module imports. |
| swanlab/data/modules/audio/init.py | Migrated import references to swanlab.toolkit. |
| swanlab/data/modules/init.py | Centralized module imports via swanlab.toolkit. |
| swanlab/data/formatter.py | Updated callback import to reference swanlab.toolkit. |
| swanlab/data/callbacker/offline.py | Revised logging to use rich Text formatting. |
| swanlab/data/callbacker/local.py | Updated logging and callback imports. |
| swanlab/data/callbacker/cloud.py | Changed logging calls to use rich Text and Status components. |
| swanlab/core_python/uploader/model.py | Updated ColumnClass and ColumnConfig imports to swanlab.toolkit. |
| swanlab/core_python/client/init.py | Replaced FONT.loading with a Status context; updated MediaBuffer import. |
| swanlab/core_python/auth/providers/api_key.py | Migrated logging and import references to rich and swanlab.toolkit. |
| swanlab/cli/commands/auth/logout.py | Updated logout messaging using rich Text; ensure consistency in output. |
| swanlab/cli/commands/auth/login.py | Refactored login messaging to use rich Text formatting. |
| docs/插件化设计.md | Updated documentation to reflect the new import path for callbacks. |
bf80e4b to
a9233e8
Compare
Zeyi-Lin
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本 PR 清理了 swankit 的导入代码，接下来我们考虑将 swankit 部分的代码合并进入 swanlab 源码中，不再分包，导入方式为：
就目前而言 swankit 依旧存在，在此过渡期本质上
swanlab/toolkit只是导入了 swankit 中的工具函数并暴露——但是未来 swankit 会被抛弃。此外，使用 rich 代替了原本自己写的高亮格式化工具，现在不会再出现 windows 字符乱码的情况。