Fix/core python #1109
Merged
Fix/core python #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses missing type definition issues noted in #1102 and consolidates the authentication logic by moving it from swanlab.api to swanlab.core_python.
- Changed multiple import paths to use swanlab.core_python.auth instead of swanlab.api.auth.
- Updated type annotations and function references in both production and test files.
- Removed outdated API authentication modules.
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tutils/setup.py | Updated import and type annotations for authentication. |
| test/unit/core_python/test_client.py | Updated authentication import references. |
| test/unit/core_python/auth/test_api_key.py | Updated authentication function calls and type hints. |
| swanlab/data/utils.py | Replaced swanlab.api authentication calls with core_python.auth calls. |
| swanlab/data/sdk.py | Updated authentication function usage for client initialization. |
| swanlab/data/callbacker/cloud.py | Changed authentication call to use core_python.auth. |
| swanlab/core_python/client/init.py | Updated type annotations to use auth.LoginInfo and authentication calls. |
| swanlab/core_python/auth/providers/api_key.py | Refactored authentication provider with updated header comments. |
| swanlab/core_python/auth/init.py | Added new module for centralized authentication export. |
| swanlab/cli/commands/sync/init.py | Updated authentication function calls in CLI sync command. |
| swanlab/cli/commands/auth/login.py | Updated authentication function call for CLI login. |
| swanlab/api/openapi/main.py | Updated authentication call to use core_python.auth. |
| swanlab/api/openapi/base.py | Updated authentication call in session refresh logic. |
| swanlab/api/info.py | Removed outdated API authentication file. |
| swanlab/api/auth/init.py | Removed obsolete authentication exports. |
| swanlab/api/init.py | Removed deprecated API module for authentication. |
Comments suppressed due to low confidence (1)
swanlab/core_python/auth/providers/api_key.py:3
- The file header indicates '@file: session.py', which does not match the actual file name 'api_key.py'. Consider updating the header to accurately reflect the file name.
@file: session.py
Zeyi-Lin
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description