Chore/opt some misc #1066
Merged
Chore/opt some misc #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the backend run.public.run_id with the frontend experiment ID format and standardizes error messages to include unknown errors.
- Removed the
run-YYYYMMDD-prefix sorun_idis now an 8-character lowercase hex string. - Refactored the
SyncErrormessage to always emit a unified prefix and fall back to “unknown error” when no response is present.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| swanlab/error.py | Simplified SyncError’s message assignment to a single expression |
| swanlab/data/run/main.py | Dropped timestamp prefix from __run_id generation |
Comments suppressed due to low confidence (1)
swanlab/data/run/main.py:82
- The new
run_idformat (8-digit hex without prefix) should have accompanying unit tests, e.g. assert it matches/^[0-9a-f]{8}$/.
self.__run_id = hex(random.randint(0, 2**32 - 1))[2:].zfill(8)
2f84f5d to
294545f
Compare
294545f to
0f3a020
Compare
Zeyi-Lin
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
修复两样东西：
run.public.run_id不应该携带run-yyyymmdd-前缀，此参数应该在后续完全与前端实验id一致，从而实现 [REQUEST] resume 功能 #1054traceId，方便定位错误:图中马赛克部分为用户上传的 URL