refactor: change backup mode to offline #1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR renames the “backup” mode to “offline” across the SDK, callbacks, environment checks, and tests to better reflect its behavior of local-only logging without cloud uploads.
- Update mode enumeration, documentation, and type hints from “backup” to “offline”
- Rename
BackupCallbackclass toOfflineCallbackand adjust imports - Adjust test names and assertions to use the new “offline” mode
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/data/test_sdk.py | Renamed test methods and calls from backup to offline |
| swanlab/env.py | Updated allowed mode list and docstring to include offline |
| swanlab/data/utils.py | Swapped BackupCallback for OfflineCallback and updated mode check |
| swanlab/data/sdk.py | Changed MODES literal, doc strings, and init logic to use offline |
| swanlab/data/run/main.py | Replaced backup mode branch with offline |
| swanlab/data/callbacker/backup.py | Renamed BackupCallback to OfflineCallback and its __str__ |
Comments suppressed due to low confidence (3)
swanlab/data/sdk.py:195
- Update this inline comment to reference the new offline mode instead of backup (e.g.,
# 校验 mode 参数并适配 offline 模式).
# 校验mode参数并适配 backup 模式
swanlab/data/utils.py:211
- The comment still refers to '备份模式'; please update it to '离线模式' (offline mode) to match the code changes.
# 1.4 . 备份模式
swanlab/data/callbacker/backup.py:18
- [nitpick] The module file is named
backup.pybut definesOfflineCallback; consider renaming this file tooffline.py(and updating import paths) to keep filenames consistent with class names.
class OfflineCallback(SwanLabRunCallback):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change backup mode to offline and fix #1033