feat: allow get npu power #1012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extends the Ascend NPU hardware metadata collector to include real-time power usage metrics for each chip.
- Initializes per-chip power chart configurations
- Introduces
get_chip_powerto fetch and parse NPU power vianpu-smi - Updates
collectto include power readings alongside utilization and temperature
Comments suppressed due to low confidence (2)
swanlab/data/run/metadata/hardware/npu/ascend.py:166
- For consistency with
per_util_configs,per_hbm_configs, andper_temp_configs, renameper_power_configtoper_power_configs.
self.per_power_config = {}
swanlab/data/run/metadata/hardware/npu/ascend.py:245
- The new
get_chip_powermethod and its integration intocollectlack accompanying tests. Consider adding unit or integration tests to validate parsing logic and error handling.
def get_chip_power(self, npu_id: str, chip_id: str) -> HardwareInfo:
Zeyi-Lin
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
ascend.pyfile by adding functionality to monitor NPU power usage. The changes include updates to the initialization method, a new method for retrieving power metrics, and integration of power data collection into the existing workflow.Additions related to NPU power monitoring:
Initialization of power monitoring configurations:
self.power_keyfor generating unique keys for NPU power metrics.power_configandself.per_power_configto store chart configurations for power usage.New method for power data retrieval:
get_chip_powermethod to fetch power usage data using thenpu-smicommand and format it into the required hardware info structure.Integration of power data into the collection process:
collectmethod to include power usage data in the results.