Feature/backup #1018
Merged
Feature/backup #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a basic framework and integration points for a new “backup” mode that writes and retains local logs without uploading to the cloud.
- Introduce a
backupflag in settings and extendmode/initlogic to handlebackup. - Refactor the core logger to dispatch to multiple handlers and inject a backup handler.
- Add stub modules and callbacks under
swanlab/log/backupandswanlab/data/callbacker/backup.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/data/callbacker/test_local.py | Updated test to call _terminal_handler instead of _write_handler. |
| swanlab/swanlab_settings.py | Added backup: StrictBool field to settings. |
| swanlab/log/log.py | Refactored to support multiple handlers and no longer take a per-handler arg. |
| swanlab/log/backup/models.py | Added stub module for backup JSON models. |
| swanlab/log/backup/init.py | Implemented BackupHandler with decorator stubs. |
| swanlab/env.py | Extended MODE enum and removed one RUNTIME value. |
| swanlab/data/utils.py | Adjusted _create_operator signature to accept login_info and cbs. |
| swanlab/data/sdk.py | Updated SDK init to support backup mode and logdir setup. |
| swanlab/data/run/main.py | Updated run initialization to control save behavior and expanded on_init flow. |
| swanlab/data/run/callback.py | Added low-level terminal/error hooks and backup integration. |
| swanlab/data/callbacker/local.py | Cleaned up old write handler, introduced _terminal_handler. |
| swanlab/data/callbacker/cloud.py | Removed duplicate utils and aligned terminal handling. |
| swanlab/data/callbacker/backup.py | Added stub callback for backup mode. |
| swanlab/api/http.py | Exposed history_exp_count and removed return from mount_project. |
Comments suppressed due to low confidence (2)
test/unit/data/callbacker/test_local.py:33
- [nitpick] The test is still named
test_local_write_handlerbut now calls_terminal_handler. Rename the test totest_local_terminal_handler(and update any references) for clarity.
def test_local_write_handler(monkeypatch):
swanlab/data/run/main.py:227
- The code uses
random.randintbutrandomis not imported in this module, leading to aNameError. Addimport randomat the top.
num = random.randint(0, 20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
完成日志备份基本框架