fix: metax type #1017
Merged
fix: metax type #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the Metax GPU metadata format by extracting the MACA version separately and normalizing key names.
- map_metax_gpu now returns
maca_versionas a separate tuple element and removes"maca"from the GPU map. - Renamed GPU mapping fields:
gpu_name→nameandgpu_memory→memory. - Cleaned up formatting: single-line
subprocess.runcalls and removed unusedjsonimport.
Comments suppressed due to low confidence (2)
swanlab/data/run/metadata/hardware/gpu/metax.py:48
- Replace the mismatched closing curly quote (
”) with a straight double-quote (") in the example for consistency.
gpu_map: {"0": { "name": "MetaX C500”, "memory": "64GB"}, "1": ...}
swanlab/data/run/metadata/hardware/gpu/metax.py:33
- Add or update unit tests for
map_metax_gputo verify thatmaca_versionis parsed correctly and not left ingpu_map.
driver, maca_version, gpu_map = map_metax_gpu()
Zeyi-Lin
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复 metax 数据格式：