Skip to content

chore: some misc #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2025
Merged

chore: some misc #995

merged 1 commit into from
May 25, 2025

Conversation

SAKURA-CAT
Copy link
Member

This pull request includes a small change in the mount_project method within the swanlab/api/http.py file. The change removes an unused variable proj_info, simplifying the code.

@SAKURA-CAT SAKURA-CAT requested review from Zeyi-Lin and Copilot May 25, 2025 11:32
@SAKURA-CAT SAKURA-CAT self-assigned this May 25, 2025
@SAKURA-CAT SAKURA-CAT added the 🐛 bug Something isn't working label May 25, 2025
Copilot
Copilot AI reviewed May 25, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an unused variable and its preceding comment from the mount_project method to simplify the code.

  • Deleted the proj_info assignment and its Chinese comment.
  • No functional change, purely code cleanup.

@SAKURA-CAT SAKURA-CAT merged commit eb410a8 into main May 25, 2025
5 checks passed
@SAKURA-CAT SAKURA-CAT deleted the chore-some-misc branch May 25, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Zeyi-Lin Zeyi-Lin Zeyi-Lin approved these changes

Assignees

@SAKURA-CAT SAKURA-CAT

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SAKURA-CAT @Zeyi-Lin