feat: compat self host api #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds compatibility for early self-hosted SwanLab versions that lack the /project endpoint by falling back to the legacy /project/{username} API.
- Catch 404 on
/projectand retry with/project/{groupname}POST/GET - Store and reuse
__groupnamefor both modern and legacy endpoints
Comments suppressed due to low confidence (1)
swanlab/api/http.py:275
- The variable
usernameis not defined in this scope. You may need to accept it as a function parameter or derive it from the initial response (e.g.,resp['username']).
self.__groupname = self.__groupname if username is None else username
0d60b7f to
4fd225f
Compare
4fd225f to
3f1a297
Compare
Zeyi-Lin
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early (private) versions of SwanLab did not have the /project endpoint. The /project/{username} endpoint had to be used instead, as the default workspace feature was not available at that time.