fix: exp color #991
Merged
fix: exp color #991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fix abnormal experience value color in cloud mode by fetching detailed project information after setting the group name.
- After assigning
self.__groupname, add a GET request to retrieve project details. - Pass the project group name and project name into the API endpoint.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the project creation flow by switching to the instance’s HTTP methods, simplifying error handling, and fetching full project details after creation.
- Replaced direct
http.postcalls withself.postto use the instance client - Removed specific 404/403 error handlers and rethrowing unexpected errors with a clarifying comment
- Added a follow-up
GETrequest to retrieve detailed project info
Comments suppressed due to low confidence (2)
swanlab/api/http.py:274
- Using
self.groupnamemay not reference the private attribute__groupnameyou set earlier; consider accessing the correct attribute or providing a public property if needed.
resp = self.get(f"/project/{self.groupname}/{name}")
swanlab/api/http.py:274
- You’ve added a new
GETcall to retrieve project details—ensure there are unit or integration tests covering this new request path.
resp = self.get(f"/project/{self.groupname}/{name}")
Zeyi-Lin
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the bug caused by #984: Abnormal display of experience value color in cloud mode.