Skip to content

Conversation

Zeyi-Lin
Copy link
Member

@Zeyi-Lin Zeyi-Lin commented Feb 5, 2025

Description

This pull request includes changes to the swanlab/data/sdk.py file to improve the initialization process by setting default values for experiment_name and description from keyword arguments if they are not provided.

Improvements to initialization process:

  • swanlab/data/sdk.py: Added logic to set experiment_name from kwargs["name"] if experiment_name is not provided, and to set description from kwargs["notes"] if description is not provided.

Closes: #809

@Zeyi-Lin Zeyi-Lin requested a review from SAKURA-CAT February 5, 2025 05:24
@Zeyi-Lin Zeyi-Lin self-assigned this Feb 5, 2025
@Zeyi-Lin Zeyi-Lin added the 💪 enhancement New feature or request label Feb 5, 2025
@SAKURA-CAT SAKURA-CAT merged commit 432bde6 into main Feb 5, 2025
5 checks passed
@SAKURA-CAT SAKURA-CAT deleted the feat/kwargs-match-wandb branch February 5, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADVICE] 用name参数等价experiment_name参数
2 participants