QMMHarmonyShimmer: Improved logging for invalid assemblies #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to shim an assembly that is not a valid format (ie. unmanaged) and improved logging for this. Also added log warnings when any version of `0Harmony.dll` is detected in a QMod subfolder to allow users, modders and support-staff alike to know that this will very likely cause issues and the mod should be updated or removed.
Alexejhero
approved these changes
Aug 6, 2020
PrimeSonic
reviewed
Aug 6, 2020
PrimeSonic
approved these changes
Aug 6, 2020
This was referenced Aug 7, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spefically catching the
BadImageFormatExceptionthrown when we attempt to shim an assembly that is not a valid format (ie. unmanaged) and improved logging for this.Also added log warnings when any version of
0Harmony.dllis detected in a QMod subfolder to allow users, modders and support-staff alike to know that this will very likely cause issues and the mod should be updated or removed.Closes #176