add set -euo pipefail to docker-entrypoint.sh files #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to build failures looks like this uncovered a can of worms, which is good in general and what it should do. Check the build logs for possible fixes. |
arm4b
reviewed
Aug 3, 2020
|
Looks like this abandoned PR is part of the v3.3.0 release. @punkrokk any update on finishing it? |
# Conflicts: # packagingenv/centos6/docker-entrypoint.sh # packagingenv/trusty/docker-entrypoint.sh # testingenv/centos6/docker-entrypoint.sh # testingenv/trusty/docker-entrypoint.sh
|
@blag and I agree this is likely a can of worms and it should be moved to
3.4.
…On Thu, Sep 10, 2020 at 9:17 AM Eugen C. ***@***.***> wrote:
Looks like this abandoned PR is part of the v3.3.0 release. @punkrokk
<https://github.com/punkrokk> any update on finishing it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#144 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIMM6SGR3KTGODXYWYXK6TSFDGYFANCNFSM4KLSULXA>
.
--
JP
|
|
A can of worms is when any failure in st2chatops deb/rpm build results in a successful status. That's a curent issue. I just pushed a tiny change to rectify issues left in this PR so we'll able to merge it. |
arm4b
approved these changes
Sep 10, 2020
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #143 as requested by @armab
Fixes #48
added the following to
docker-entrypoint.shfiles in all packaging and testing containers: