Allow PEP 440 direct references in requirements (dist_utils.py) #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for PEP 440 requirements instead of using the pip-specific VCS format. see: https://peps.python.org/pep-0440/\#direct-references This facilitates using newer tooling that does not support using the legacy pip VCS format.
nzlosh
approved these changes
Jul 17, 2022
rush-skills
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for PEP 440 requirements instead of using the pip-specific VCS format.
see: https://peps.python.org/pep-0440/\#direct-references
This facilitates using newer tooling that does not support using the legacy pip VCS format.
Here is a VCS style requirement:
st2-packages/packages/st2/in-requirements.txt
Line 9 in 6f64885
Here is a PEP 440 requirement:
st2-packages/packages/st2/in-requirements.txt
Line 9 in 8e0e574
This PR is based on StackStorm/st2#5673 and must be merged before StackStorm/st2#5673 CI can pass. This can safely be merged before StackStorm/st2#5673 is ready w/ approvals, however, as it adds support for PEP 440 without removing support for the old pip VCS requirements. In other words, we don't need to synchronize merging both PRs at the same time.
NB: I'm not changing
packages/st2/in-requirements.txtin this PR because fixate-requirements does not handle that yet. We'll adjust fixate-requirements later if needed.