Skip to content

bugfix/ISSUE-5934-fix-rbac-kv-value-render #5936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 21, 2023
Merged

bugfix/ISSUE-5934-fix-rbac-kv-value-render #5936

merged 5 commits into from
Nov 21, 2023

Conversation

jschoewe
Copy link
Contributor

@jschoewe jschoewe commented Mar 14, 2023 •
edited by arm4b
Loading

Moved permission checks into if statement because we don't need to run checks if no key was found.

This is a fix for the following issue:
Closes #5934

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Mar 14, 2023
@CLAassistant
Copy link

CLAassistant commented Mar 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jschoewe jschoewe mentioned this pull request Mar 14, 2023
Closed
@cognifloyd cognifloyd mentioned this pull request Mar 14, 2023
Closed
@rush-skills
Copy link
Member

Any idea why the CI is failing?

@amanda11 amanda11 added this to the 3.9.0 milestone Apr 13, 2023
@amanda11
Copy link
Contributor

@jschoewe Please could you sign the CLA, see message above.

@guzzijones
Copy link
Contributor

I also just hit this bug. Knowing that I need to add the key store value helped me resolve it. Thanks.

guzzijones
guzzijones approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@guzzijones guzzijones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we should not check rbac if no key value is found.

@nzlosh nzlosh enabled auto-merge (squash) September 14, 2023 11:26
@nzlosh
Copy link
Contributor

nzlosh commented Sep 14, 2023

@jschoewe Would you be able to rebase your branch against master so this PR can be merged please?

@arm4b arm4b modified the milestones: 3.9.0, 3.8.1 Nov 21, 2023
@arm4b arm4b disabled auto-merge November 21, 2023 14:17
@arm4b
Copy link
Member

arm4b commented Nov 21, 2023

Tagging this for the upcoming v3.8.1 patch release.

@jschoewe Could you please update the branch with the latest st2 upstream so we can merge the PR?
I couldn't push to your fork.

@arm4b arm4b enabled auto-merge November 21, 2023 14:25
@arm4b arm4b merged commit 57c7964 into StackStorm:master Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzlosh nzlosh nzlosh approved these changes

@guzzijones guzzijones guzzijones approved these changes

+1 more reviewer

@arm4b arm4b arm4b approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.

Unable to render KV store params in actions when RBAC is enabled
7 participants
@jschoewe @CLAassistant @rush-skills @amanda11 @guzzijones @nzlosh @arm4b