Skip to content

Conversation

cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Mar 10, 2023

Background

This is another part of introducing pants, as discussed in various TSC meetings.

Related PRs can be found in:

Overview of this PR

I missed 3 BUILD files in #5926, so this reclassifies those sources as well.

This replaces a [3] python_sources targets with python_test_utils. I excluded the test_*.py files in tests/unit directories since those are already covered by python_tests targets.

This PR does not make any functional changes - to Pants, python_sources and python_test_utils are functionally equivalent. So, this is a very minor/small PR.

I also noticed a typo (paths weren't relative but should have been) in st2actions/BUILD, so I included that as well.

Pants documentation

@cognifloyd cognifloyd added this to the pants milestone Mar 10, 2023
@cognifloyd cognifloyd requested review from winem, arm4b, nzlosh, rush-skills, amanda11 and a team March 10, 2023 19:52
@cognifloyd cognifloyd self-assigned this Mar 10, 2023
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Mar 10, 2023
@cognifloyd cognifloyd enabled auto-merge March 10, 2023 19:59
@cognifloyd cognifloyd requested a review from a team March 13, 2023 15:15
Copy link
Contributor

@bishopbm1 bishopbm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cognifloyd cognifloyd merged commit a87585c into master Mar 14, 2023
@cognifloyd cognifloyd deleted the pants-reclassify-test_utils branch March 14, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pantsbuild size/S PR that changes 10-29 lines. Very easy to review. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants