Skip to content

Conversation

cognifloyd
Copy link
Member

Background

This is another part of introducing pants, as discussed in various TSC meetings.

Related PRs can be found in:

Overview of this PR

This is a grab-bag of minor fixes I've noticed.

  • These packages do nothing but re-export symbols, which makes it harder to find where things are defined. So, I replaced imports from them with where the symbols are actually defined.
    I would like to delete these - any objections? Do we need to worry about backwards compat for these internal-only bits?
    • st2common.persistence.reactor
    • st2common.models.db.reactor
  • Use a relative dep in contrib/packs/tests/BUILD because it feels cleaner.
  • Add comments about how to regenerate the lockfile in requirements-pants.txt and lockfiles/st2-constraints.txt.
  • Drop the execute bit on st2common/st2common/cmd/*.py. These have no "main" check, so they're not directly executable. The real executables are in st2common/bin, and those do have the proper execute bit set.
  • Correct some copy/pasta comments that mentioned the wrong resource.

And drop the pointless execute bit. The execute bit is only needed on
the scripts in st2common/bin, not the underlying python files.
Make it clearer where things come from so tracking things down is easier.
in:
- lockfiles/st2-constraints.txt
- requirements-pants.txt
@cognifloyd cognifloyd added this to the pants milestone Mar 8, 2023
@cognifloyd cognifloyd requested review from winem, arm4b, nzlosh, rush-skills, amanda11 and a team March 8, 2023 03:49
@cognifloyd cognifloyd self-assigned this Mar 8, 2023
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Mar 8, 2023
@cognifloyd cognifloyd merged commit 14e98ca into master Mar 8, 2023
@cognifloyd cognifloyd deleted the misc-cleanups branch March 8, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pantsbuild refactor size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants