Skip to content

delete pointless py header in empty __init__.py #5671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2022
Merged

delete pointless py header in empty __init__.py #5671

merged 3 commits into from
Jul 19, 2022

Conversation

cognifloyd
Copy link
Member

__init__.py files only need a copyright header if there's actually something in the file.

Plus, pants can skip introspecting files when they are empty. So having a comment-only python file is wasteful.

@cognifloyd cognifloyd added this to the 3.8.0 milestone Jul 16, 2022
@cognifloyd cognifloyd added no changelog No Changelog.rst needed for this PR refactor labels Jul 16, 2022
@cognifloyd cognifloyd self-assigned this Jul 16, 2022
@cognifloyd cognifloyd requested a review from a team July 16, 2022 22:37
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Jul 16, 2022
amanda11
amanda11 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cognifloyd cognifloyd merged commit c66e55b into master Jul 19, 2022
@cognifloyd cognifloyd deleted the drop-init-header branch July 19, 2022 15:20
@cognifloyd cognifloyd mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rush-skills rush-skills rush-skills approved these changes

@amanda11 amanda11 amanda11 approved these changes

Assignees

@cognifloyd cognifloyd

Labels
no changelog No Changelog.rst needed for this PR pantsbuild refactor size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cognifloyd @rush-skills @amanda11