Skip to content

#5460 - Include pysocks in st2client #5469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Conversation

kingsleyadam
Copy link
Contributor

Without pysocks PyPi package SOCKS proxies won't work with the following errors.

ERROR: Missing dependencies for SOCKS support.

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Dec 1, 2021
@CLAassistant
Copy link

CLAassistant commented Dec 1, 2021

CLA assistant check
All committers have signed the CLA.

@arm4b arm4b added this to the 3.7.0 milestone Jan 5, 2022
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Looks like the tests are passing.
Could you please include a Changelog for this PR as well?

@kingsleyadam
Copy link
Contributor Author

Thanks for the contribution!

Looks like the tests are passing. Could you please include a Changelog for this PR as well?

Yep! Changelog updated.

@arm4b arm4b merged commit 1faf978 into StackStorm:master Jan 6, 2022
@arm4b
Copy link
Member

arm4b commented Jan 6, 2022

@kingsleyadam Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants