Add a custom gunicorn sync worker implementation which works around some issues #2571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome issues which occur when eventlet monkey patching is used with sync worker.
|
@Kami - where did you find out that this was the workaround. Did you read gunicorn code to decide which method to overwrite? |
|
@manasdk Yep, I checked the sync and base worker implementation. Without that it fails with the error below inside assert hub.greenlet is not current, 'do not call blocking functions from the mainloop'
AssertionError: do not call blocking functions from the mainloopI'm not too big of a fan of this work-around, but dunno. There are also other issues with async (eventlet) based worker. |
|
@Kami If you want to still merge this change please include reference to code from gunicorn in the new file so it is easy for someone to track this down in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a custom sync worker implementation which includes a work-around for shutdown related issues when using sync worker in combination with eventlet monkey patching,.