Skip to content

StackStorm v3.3.0 Pre-release Testing #52

New issue
New issue
Closed
Closed
StackStorm v3.3.0 Pre-release Testing#52
Assignees
Kamiblagmickmcgrath13punkrokkarm4bm4dcodernmaludyamanda11
Labels
communityplanrelease
@nmaludy

Description

@nmaludy
nmaludy
opened on Oct 9, 2020

We're ready to prepare the StackStorm v3.3 release and starting pre-release testing..

Release Process Preparation

Per Release Management Schedule @nmaludy is the Release Manager and @blag Assisting for v3.3. They will freeze the master for the major repositories in StackStorm org, follow the StackStorm Release Process which is now available to public, accompanied by the Useful Info for Release managers. Communication is happening in #releasemgmt and #development Slack channels.
The first step is pre-release manual user-acceptance testing for v3.3dev.

Why Manual testing?

StackStorm is very serious about testing and has a lot of it: Unit tests, Integration, Deployment/Integrity checks, Smoke tests and eventually end-2-end tests when automation spins up new AWS instance for each OS/flavor we support, installs real st2 like user would and runs set of st2tests (for each st2 PR, nightly, periodically, during release).

See st2ci and st2cd for more examples and workflows about how StackStorm automation is used to test StackStorm (dogfooding).

That's a perfect way to verify what we already know and codify expectations about how StackStorm should function.

However it's not enough.
There are always new unknowns to discover, edge cases to experience and tests to add. Hence, manual Exploratory Testing is an exercise where entire team gathers together and starts trying (or breaking) new features before the new release. Because we're all different, perceive software differently and try different things we might find new bugs, improper design, oversights, edge cases and more.

This is how StackStorm previously managed to land less major/critical bugs into production.

TL;DR

Install StackStorm v3.3dev unstable packages, try random things in random environments (different OS) and report any regressions found comparing to v3.2:

curl -sSL https://stackstorm.com/packages/install.sh | bash -s -- --user=st2admin --password=Ch@ngeMe --unstable

Extra points for PR hotfixes and adding new or missing test cases.

Major changes

  • Mistral removal
    • Ensure Mistral and Postgres are no longer installed (st2mistral, mistral, postgres, etc)
  • Removal of EL6 support
  • Deprecation of Python 2
    • Ensure proper warnings are shown
  • MongoDB 4.0
    • Ensure MongoDB 4.0 is installed with latest version
    • Ensure no issues or performance regressions are observed
  • Remove authentication headers St2-Api-Key, X-Auth-Token and Cookie from webhook payloads to prevent them from being stored in the database. (security bug fix) #4983
    • Write a webhook rule and send it these headers to the webhook, ensure that the trigger doesn't contain these header values
  • Removal of HipChat support in st2chatops
  • st2web dependencies have been upgraded for security reasons, need to do a thorough walk-through to ensure nothing is broken
  • Depreacation of chef-stackstorm
  • st2-docker revamp based on st2-dockerfiles

Full Changelog

Changes which are recommended to ack, explore, check and try in a random way.

st2

Added

  • Add make command to autogen JSON schema from the models of action, rule, etc. Add check
    to ensure update to the models require schema to be regenerated. (new feature)

  • Improved st2sensor service logging message when a sensor will not be loaded when assigned to a
    different partition (@punkrokk) #4991

  • Add support for a configurable connect timeout for SSH connections as requested in #4715
    by adding the new configuration parameter ssh_connect_timeout to the ssh_runner
    group in st2.conf. (new feature) #4914

    This option was requested by Harry Lee (@tclh123) and contributed by Marcel Weinberg (@winem).

  • Added a FAQ for the default user/pass for the tools/launch_dev.sh script and print out the
    default pass to screen when the script completes. (improvement) #5013

    Contributed by @punkrokk

  • Added deprecation warning if attempt to install or download a pack that only supports
    Python 2. (new feature) #5037

    Contributed by @amanda11

  • Added deprecation warning to each StackStorm service log, if service is running with
    Python 2. (new feature) #5043

    Contributed by @amanda11

  • Added deprecation warning to st2ctl, if st2 python version is Python 2. (new feature) #5044

    Contributed by @amanda11

Changed

  • Switch to MongoDB 4.0 as the default version starting with all supported OS's in st2
    v3.3.0 (improvement) #4972

    Contributed by @punkrokk

  • Added an enhancement where ST2api.log no longer reports the entire traceback when trying to get a datastore value
    that does not exist. It now reports a simplified log for cleaner reading. Addresses and Fixes #4979. (improvement) #4981

    Contributed by Justin Sostre (@saucetray)

  • The built-in st2.action.file_writen trigger has been renamed to st2.action.file_written
    to fix the typo (bug fix) #4992

  • Renamed reference to the RBAC backend/plugin from enterprise to default. Updated st2api
    validation to use the new value when checking RBAC configuration. Removed other references to
    enterprise for RBAC related contents. (improvement)

  • Remove authentication headers St2-Api-Key, X-Auth-Token and Cookie from webhook payloads to
    prevent them from being stored in the database. (security bug fix) #4983

    Contributed by @potato and @knagy

Fixed

  • Fixed a bug where type attribute was missing for netstat action in linux pack. Fixes #4946

    Reported by @scguoi and contributed by Sheshagiri (@Sheshagiri)

  • Fixed a bug where persisting Orquesta to the MongoDB database returned an error
    message: key 'myvar.with.period' must not contain '.'. This happened anytime an
    input, output, publish or context var contained a key with a . within
    the name (such as with hostnames and IP addresses). This was a regression introduced by
    trying to improve performance. Fixing this bug means we are sacrificing performance of
    serialization/deserialization in favor of correctness for persisting workflows and
    their state to the MongoDB database. (bug fix) #4932

    Contributed by Nick Maludy (@nmaludy Encore Technologies)

  • Fix a bug where passing an empty list to a with items task in a subworkflow causes
    the parent workflow to be stuck in running status. (bug fix) #4954

  • Fixed a bug in the example nginx HA template declared headers twice (bug fix) #4966
    Contributed by @punkrokk

  • Fixed a bug in the paramiko_ssh runner where SSH sockets were not getting cleaned
    up correctly, specifically when specifying a bastion host / jump box. (bug fix) #4973

    Contributed by Nick Maludy (@nmaludy Encore Technologies)

  • Fixed a bytes/string encoding bug in the linux.dig action so it should work on Python 3
    (bug fix) #4993

  • Fixed a bug where a python3 sensor using ssl needs to be monkey patched earlier. See also #4832, #4975 and SSLContext infinite recursion in Python 3.6 gevent/gevent#1016 (bug fix) #4976

    Contributed by @punkrokk

  • Fixed bug where action information in RuleDB object was not being parsed properly
    because mongoengine EmbeddedDocument objects were added to JSON_UNFRIENDLY_TYPES and skipped.
    Removed this and added if to use to_json method so that mongoengine EmbeddedDocument
    are parsed properly.

    Contributed by Bradley Bishop (@bishopbm1 Encore Technologies)

  • Fix a regression when updated dnspython pip dependency resulted in
    st2 services unable to connect to mongodb remote host (bug fix) #4997

  • Fixed a regression in the linux.dig action on Python 3. (bug fix) #4993

    Contributed by @blag

  • Fixed a bug in pack installation logging code where unicode strings were not being
    interpolated properly. (bug fix)

    Contributed by @misterpah

  • Fixed a compatibility issue with the latest version of the logging library API
    where the find_caller() function introduced some new variables. (bug fix) #4923

    Contributed by @Dahfizz9897

Removed

  • Removed Mistral workflow engine (deprecation) #5011

    Contributed by Amanda McGuinness (@amanda11 Ammeon Solutions)

  • Removed CentOS 6/RHEL 6 support #4984

    Contributed by Amanda McGuinness (@amanda11 Ammeon Solutions)

  • Removed our fork of codecov-python for CI and have switched back to the upstream version (improvement) #5002

orquesta

Fixed

  • Warn users when there is a loop and no start task identified. (bug fix)
  • Lock global variables during initialization to make them thread safe. (bug fix)
  • Workflow stuck in running if one or more items failed in a with items task. (bug fix)

st2chatops

st2web

Conclusion

Please report findings here and bugs/regressions in respective repositories.
Depending on severity and importance bugs might be fixed before the release or postponed to the next release if they're very minor and not a release blocker.

Issues Found During Release

PRs Merged for Release

TODOs

  • Blog post for orquestaconvert
  • Blog post for release
  • Blog post for exchange/community update

Metadata

Metadata

Assignees

Labels

communityplanrelease

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions