feat: List extension: fast remove method by swap elements #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y index, by item and by predicate evaluation
stan-osipov
requested changes
Jul 16, 2021
There was a problem hiding this comment.
Looks good.
But please convert this test:
Tested in Unity Editor. See link below:
https://share.getcloudapp.com/RBulD2kG
To the actual Uini test.
|
@Yurii-Tor any luck with the test? |
I'm working on it now. Just started |
stan-osipov
reviewed
Jul 21, 2021
stan-osipov
requested changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fast method for removing elements from List implemented.
This feature is often on demand. It changes an order of elements inside the list, so not recomended if order matters. Instead of that LinkedList may be used if it feats needs (it's not an IList type)
Testing status
Manual testing status
Tested in Unity Editor. See link below:
https://share.getcloudapp.com/RBulD2kG
Comments to reviewers
Notice that 'Remove' method deletes only one element, so the predicate evaluation deletes only the first founded. If you need to delete all evaluated elements, use RemoveAll method, which is also fast and doesn't allocate additional resources.