pyzstd_pep517: name config_settings argument correctly #2
Conversation
|
Hello @gotmax23 and thank you for your patch! I understand that the argument you changed is a positional or keyword parameter (e.g. Could you tell a bit more about the context in which you are having an issue with this? For example, if your build system fails to build This will be helpful not only to reproduce, but also to give a proper importance level to this fix. Thank you! |
Sure!
I am using https://src.fedoraproject.org/rpms/pyproject-rpm-macros which is the build frontend tool we use for building python project RPMs for Fedora Linux (and Red Hat Enterprise Linux and CentOS and others). I am working on importing pyzstd into the official Fedora repositories. |
|
Thank you for the explanations! This will be shipped in next release (current target is by the end of May). |
|
Fixed in version 0.16.0 that has just been released 🚀 |
PEP 517 says that the argument should be named config_settings but pip/pyproject-hooks and other build frontends just pass it as a positional argument, so some build backends name this argument other things. Even though those build backends are wrong, it still makes sense to align pyproject-rpm-macros with what the other frontends do. Ref: PyO3/maturin#2612 Ref: Rogdham/pyzstd#2
Ref: https://peps.python.org/pep-0517/#get-requires-for-build-wheel