test: Update p2p_ibd_tx_relay.py to support minrelaytxfee as low as 1… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reardencode
reviewed
Jul 13, 2025
|
|
||
|
|
||
| class P2PIBDTxRelayTest(BitcoinTestFramework): | ||
| def set_test_params(self): | ||
| self.setup_clean_chain = True | ||
| self.num_nodes = 2 | ||
| self.extra_args = [ | ||
| ["-minrelaytxfee={}".format(NORMAL_FEE_FILTER)], | ||
| ["-minrelaytxfee={}".format(NORMAL_FEE_FILTER)], | ||
| ["-minrelaytxfee={:.8f}".format(NORMAL_FEE_FILTER)], |
There was a problem hiding this comment.
Its a formatting issue with ParseMoney in src/util/moneystr.cpp. It rejects the small value default encoding of scientific notation, so the formatting change sets it up as a regular decimal. It can parse 1e-6 (what we had previously) but it will not parse 1e-7 (where we are now with the change. Adding 8 decimal places fixes this so it is 0.00000010.
There was a problem hiding this comment.
Languages who cannot consistently roundtrip their own formatting are the root of all evil.
|
Ack 0e34e65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
test/functional/p2p_ibd_txrelay.pyto align with the reducedDEFAULT_MIN_RELAY_TX_FEEof 100 sats/kvB.Changes
Adjusted
NORMAL_FEE_FILTERScaled down from
Decimal(100) / COINtoDecimal(10) / COINto reflect the 10× reduction in the default min relay fee.Updated
MAX_FEE_FILTERChanged from
Decimal(9170997) / COINtoDecimal(9936506) / COINto match the output ofFeeFilterRounderunder the new lower default. This avoids timeout-related test failures due to mismatched filter expectations.