Skip to content

Add robot deletion confirmation dialog #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Add robot deletion confirmation dialog #2028

merged 1 commit into from
Jun 27, 2025

Conversation

proaktib
Copy link
Contributor

What does this PR do?

Implements #1805

  • Add DeleteRobotConfirmationDialog component with warning messages
  • Update RobotProfile to show confirmation before deletion
  • Include safety reminders about storing robot tokens
  • Prevent accidental robot deletion with proper UX patterns

image

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

@proaktib
Add robot deletion confirmation dialog
e535273 
- Add DeleteRobotConfirmationDialog component with warning messages
- Update RobotProfile to show confirmation before deletion
- Include safety reminders about storing robot tokens
- Prevent accidental robot deletion with proper UX patterns

Fixes RoboSats#1805
@proaktib proaktib mentioned this pull request Jun 27, 2025
Closed
KoalaSat
KoalaSat approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@KoalaSat KoalaSat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @proaktib awesome work, thank you.

Please accept a tip: Share here a Lightning invoice with a long expiration date for 50,000 sats

@KoalaSat KoalaSat merged commit 3732c03 into RoboSats:main Jun 27, 2025
@proaktib
Copy link
Contributor Author

Nice! 👏

lnbc500u1p59lq0jpp5vp5qrma9c0kgcq0hgpecr3q3gcur2ahzjv5e3xclp2m6gw0sf9nsdqqcqzzsxqyz5vqsp58jkcs558cuxn5cqwdaxluplswahesng9ce36xkcqg0kv4ek7j6as9qxpqysgqm6sja2f8qlqmlefequmty2rnqh8zu5wl923dl7g5pla4k04envn48rjss8d53zmufqr80nqmq6xqyfqhpnrtmndczcgjal498sgnppsqhsht27

@proaktib proaktib deleted the feature/robot-deletion-confirmation branch June 28, 2025 05:49
@KoalaSat
Copy link
Member

Nice! 👏

lnbc500u1p59lq0jpp5vp5qrma9c0kgcq0hgpecr3q3gcur2ahzjv5e3xclp2m6gw0sf9nsdqqcqzzsxqyz5vqsp58jkcs558cuxn5cqwdaxluplswahesng9ce36xkcqg0kv4ek7j6as9qxpqysgqm6sja2f8qlqmlefequmty2rnqh8zu5wl923dl7g5pla4k04envn48rjss8d53zmufqr80nqmq6xqyfqhpnrtmndczcgjal498sgnppsqhsht27

649ab4554a360aa4d5bd0bcccaf9d12268a7e2e9c04ff1ee947ed54e6460eb4c

@proaktib
Copy link
Contributor Author

Nice! 👏
lnbc500u1p59lq0jpp5vp5qrma9c0kgcq0hgpecr3q3gcur2ahzjv5e3xclp2m6gw0sf9nsdqqcqzzsxqyz5vqsp58jkcs558cuxn5cqwdaxluplswahesng9ce36xkcqg0kv4ek7j6as9qxpqysgqm6sja2f8qlqmlefequmty2rnqh8zu5wl923dl7g5pla4k04envn48rjss8d53zmufqr80nqmq6xqyfqhpnrtmndczcgjal498sgnppsqhsht27

649ab4554a360aa4d5bd0bcccaf9d12268a7e2e9c04ff1ee947ed54e6460eb4c

Received! Many thanks! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoalaSat KoalaSat KoalaSat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proaktib @KoalaSat