Skip to content

Conversation

htteot
Copy link
Contributor

@htteot htteot commented Jun 16, 2025

What does this PR do?

Fixes #<ISSUE_NUMBER>

This PR introduces/refactors/...

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

@KoalaSat
Copy link
Member

Hi! Can you expose here the reasons to remove those wallets? Just to keep track of it

@htteot
Copy link
Contributor Author

htteot commented Jun 18, 2025

Wallets Mutiny and Phoenix have been removed due to:

  • Mutiny:
    -- wallet shutdown and the end of support:
    --- https://blog.mutinywallet.com/mutiny-wallet-is-shutting-down/

  • Phoenix:
    -- wallet team does not want to support the lock invoice used by Robosats:
    --- chat conversation: "Hello, Locking payments is a hack that puts strain on the network. Phoenix won't allow unreasonably high lock time. But if the lock time is reasonable, then it should work. Best, Phoenix support"
    ---- Based on the tests, all transactions using this wallet failed in Robosats so I am removing this wallet. Waiting for their policy to change before adding it back.

@KoalaSat
Copy link
Member

KoalaSat commented Jun 19, 2025

Wallets Mutiny and Phoenix have been removed due to:

  • Mutiny:
    -- wallet shutdown and the end of support:
    --- https://blog.mutinywallet.com/mutiny-wallet-is-shutting-down/
  • Phoenix:
    -- wallet team does not want to support the lock invoice used by Robosats:
    --- chat conversation: "Hello, Locking payments is a hack that puts strain on the network. Phoenix won't allow unreasonably high lock time. But if the lock time is reasonable, then it should work. Best, Phoenix support"
    ---- Based on the tests, all transactions using this wallet failed in Robosats so I am removing this wallet. Waiting for their policy to change before adding it back.

I see now. I agree on removing Mutiny if the wallet is shutting down. But that's not the case of Phoenix so people will continue trying to use it for Robosats, I think that we should just update the row instead or removing it. What do you think?

@htteot
Copy link
Contributor Author

htteot commented Jun 19, 2025

I agree

htteot added 3 commits June 19, 2025 20:06
Remove word RoboSats from transaction description
@htteot
Copy link
Contributor Author

htteot commented Jun 19, 2025

I have also updated logics.py file to replace string 'RoboSats' with string 'the trading platform'.
This is to increase the privacy and make surveillance a bit less easy.
Currently every transaction contains a reference to RoboSats platform exposing what the user of the Lightning wallet is doing.
This data can be potentially collected by the Lightning wallet operator or Lightning liquidity providers.

@KoalaSat KoalaSat merged commit a4e977c into RoboSats:main Jun 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants