Skip to content

fix warnings DecimalField should be Decimal type #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2024
Merged

fix warnings DecimalField should be Decimal type #1334

merged 1 commit into from
Jun 16, 2024

Conversation

jerryfletcher21
Copy link
Contributor

What does this PR do?

The warnings were caused by the validators MinValueValidator and MaxValueValidator inside a DecimalField.

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

@Reckless-Satoshi
Copy link
Collaborator

Thank you @jerryfletcher21 these warning were annoying. I believe they came in with the Django v5 update, I eliminated some of them but missed these ones. Please submit an invoice for 20K and a loong expiration time (+1 week) for a small Dev Fund tip 🚀

@Reckless-Satoshi Reckless-Satoshi merged commit 1f2a1ab into RoboSats:main Jun 16, 2024
@jerryfletcher21
Copy link
Contributor Author

jerryfletcher21 commented Jun 18, 2024 •
edited
Loading

Please submit an invoice for 20K and a loong expiration time (+1 week) for a small Dev Fund tip 🚀

lnbc200u1pn8yxdcsp56mz8378rlywdj5dz0xlgnmsccz3rhpkgp4wt4nn67ty00sttc5rspp5xr9yw6hygphmf490dghnvkdrarnnn0kxaslyldlsy3ezug035xwqdqqxq9zf6sqcqzysrzjqdllz2m2fe9ukju5fdkjptcgehlkrv6xrswl7rgq4zrfws2d3yduwr8j0yqpv2sqqqqqqqlgqqqqp9sq2q9qxpqysgqzzrwkp5v06k9ae4j57uqya6l7lsz6g049xd4kqz57kvt7wx5qhk48h28vfe7fex9dgmrez9egpamwspjxahnl2rustygclhvraw877cqlsfkl0

@jerryfletcher21 jerryfletcher21 mentioned this pull request Jul 11, 2025
Merged
1 task
@jerryfletcher21
Copy link
Contributor Author

@KoalaSat

lnbc200u1p58pud5sp5zw2vgg2dkatrp8pe27vahqzxmdtvztrvm9a2x9pva9qwr5rgr9kqpp5yk2h96guxpc87rnd7rvuwargwa6d2239ra7gzvavpee7pcsgdzvqdqqxq9yn4qqcqzysrzjqdllz2m2fe9ukju5fdkjptcgehlkrv6xrswl7rgq4zrfws2d3yduwr8j0yqpv2sqqqqqqqlgqqqqp9sq2q9qxpqysgqxsz93kfk36sapestgz873tgzgg7c0hmd670peqf8r7z4ndv2820srquh6dhnqrujxr37mm5wqjv54uwphqrht2exczeegpkx9p2g85cqqdxagj

@KoalaSat
Copy link
Member

6c5cb6062a445fb096d207bacaf12f7b1a79652b4f636b062d8ab66a6cc62424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerryfletcher21 @Reckless-Satoshi @KoalaSat