Skip to content

small fix in get_exchange_rates #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2024
Merged

small fix in get_exchange_rates #1365

merged 1 commit into from
Jul 7, 2024

Conversation

jerryfletcher21
Copy link
Contributor

What does this PR do?

While running tests, the print(e) was printing an annoying list of currencies.
Removing it it is also more coherent with the other currencies providers below.

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

@jerryfletcher21
small fix in get_exchange_rates
32aee2d 
While running tests, the print(e) was printing an annoying list of
currencies. Removing it it is also more coherent with the other
currencies providers below.
@Reckless-Satoshi
Copy link
Collaborator

Nice, thank you for this fix!

Merging! 🚀 Please post an invoice for 15K with a veeery long expiration time (I keep missing them).

@Reckless-Satoshi Reckless-Satoshi merged commit 35d37e6 into RoboSats:main Jul 7, 2024
@jerryfletcher21
Copy link
Contributor Author

Please post an invoice for 15K with a veeery long expiration time (I keep missing them).

lnbc150u1png4n8tsp5u7r5yt4e2z9per38cj0l3duzlkj3980cmruss392pupmvfl3glzqpp5cterzp9wjecndkxt4rgqxmcl9cu0yreuxxhe4sg7s8ntqh6mu7nsdqqxq9zf6sqcqzysrzjqdllz2m2fe9ukju5fdkjptcgehlkrv6xrswl7rgq4zrfws2d3yduwr8j0yqpv2sqqqqqqqlgqqqqp9sq2q9qxpqysgq0dr8njzv6vxet3zfmts0t6f4f774p4v0dynmknj5xclekjeqkv5x7lvw3z48ggdzvss5pvllxuvlet48qvya7lpn9hnc7ytl98crdsgpatju0s

@jerryfletcher21 jerryfletcher21 mentioned this pull request Jul 11, 2025
Merged
1 task
@jerryfletcher21
Copy link
Contributor Author

@KoalaSat

lnbc150u1p58pujdsp5jf2gf4y8w2c35k6xtxwjv0h95wy9w3sqc9gvmgj0599d5z82dntspp5wlka5l4c48n7avjacskgdn82cxgm3mx43mruhda6xx0kt05r6qssdqqxq9yn4qqcqzysrzjqdllz2m2fe9ukju5fdkjptcgehlkrv6xrswl7rgq4zrfws2d3yduwr8j0yqpv2sqqqqqqqlgqqqqp9sq2q9qxpqysgqkm3gw6w9hc0tly8uaea9s4e6drs242uxunpht3w93ss3jcnmu9vjnwnkg34dy6ltct90nynqyeztztengkvp0hlnh7nl70am80ntclsqcttkzp

@KoalaSat
Copy link
Member

62882c2adf2c2d0294b0495a6475eaec4e45745cef42c0ebd7bb4668b48eeb6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerryfletcher21 @Reckless-Satoshi @KoalaSat