BIP 158: Update filter construction #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
requested changes
Feb 1, 2018
gcs/builder/builder.go
Outdated
| return gcs.BuildGCSFilter(b.p, b.key, b.data) | ||
| dataSlice := make([][]byte, 0, len(b.data)) | ||
| for encoded := range b.data { | ||
| item, err := base64.StdEncoding.DecodeString(encoded) |
There was a problem hiding this comment.
I think we can actually just do string(encoded) here. We don't need the encoding outside this function at all (doesn't need to be human readable), and IIRC there're fast paths in the compiler for things like map[string(kek)] = 9.
gcs/gcs.go
Outdated
| @@ -98,7 +102,7 @@ func BuildGCSFilter(P uint8, key [KeySize]byte, data [][]byte) (*Filter, error) | |||
| if len(data) == 0 { | |||
| return nil, ErrNoData | |||
| } | |||
| if len(data) > math.MaxInt32 { | |||
| if len(data) > math.MaxUint32 { | |||
There was a problem hiding this comment.
IIRC we changed this as we had issues on 32-bit arm. I'll check to see if this compiles properly on my pi.
There was a problem hiding this comment.
You might be right -- I'll rewrite this line to be safe.
|
|
||
| // Count the 1s until we reach a 0. | ||
| c, err := b.ReadBit() | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
| for c { | ||
| v++ | ||
| quotient++ |
Roasbeef
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various things to update implementation to match latest revision of BIP 158.