[NEW] Added endpoint to get the list of available oauth services #10144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaelks, could you take a look, please? |
rafaelks
reviewed
Mar 14, 2018
| @@ -18,6 +18,26 @@ RocketChat.API.v1.addRoute('info', { authRequired: false }, { | |||
| } | |||
| }); | |||
|
|
|||
| RocketChat.API.v1.addRoute('oAuthServices', { authRequired: false }, { | |||
There was a problem hiding this comment.
What do you think about settings.oauth?
rename endpoind to settings.oauth and fix lint problems
|
Docs. |
rafaelks
approved these changes
Mar 14, 2018
There was a problem hiding this comment.
Just confirmed, it is working fine (@filipedelimabrito can use Heroku instance to test it for now):
$ curl -X GET "https://rocket-chat-pr-10144.herokuapp.com/api/v1/settings.oauth" | python -mjson.tool
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 95 0 95 0 0 136 0 --:--:-- --:--:-- --:--:-- 136
{
"services": [
{
"appId": "clientIdTest",
"id": "z4o9zPBYYLEAWGnXZ",
"name": "github"
}
],
"success": true
}|
@MarcosSpessatto Thank you!!! 👊 |
|
Cool! Thank you! |
rodrigok
reviewed
Mar 15, 2018
| id: service._id, | ||
| name: service.service, | ||
| appId: service.appId || service.clientId | ||
| }; |
There was a problem hiding this comment.
Why not return buttonLabelText, buttonLabelColor and buttonColor?
Added buttons Properties to response in settings.oauth endpoint
fix lint problem
rodrigok
approved these changes
Mar 15, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8519.
Added endpoint to get the list of available oauth services.