Skip to content

[FIX] User preferences can't be saved when roles are hidden in admin settings #10051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2018
Merged

[FIX] User preferences can't be saved when roles are hidden in admin settings #10051

merged 1 commit into from
Mar 7, 2018

Conversation

Hudell
Copy link
Contributor

@Hudell Hudell commented Mar 7, 2018 •
edited by rodrigok
Loading

@RocketChat/core

Closes #10049
Closes #10001

Fixed issue that caused user preferences to not be saved when roles are hidden in the admin settings

@Hudell Hudell added this to the 0.63.0 milestone Mar 7, 2018
@rodrigok rodrigok changed the title [FIX] Fixed bug on user preferences save button [FIX] User preferences can't be saved when roles are hidden in admin settings Mar 7, 2018
@rodrigok rodrigok merged commit b4bff0c into RocketChat:develop Mar 7, 2018
@Hudell Hudell mentioned this pull request Mar 29, 2018
Closed
@rodrigok rodrigok mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@karlprieb karlprieb karlprieb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.63.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Hudell @karlprieb @rodrigok