Skip to content

[FIX] Broken video call accept dialog #9872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2018
Merged

[FIX] Broken video call accept dialog #9872

merged 1 commit into from
Mar 26, 2018

Conversation

ramrami
Copy link
Contributor

@ramrami ramrami commented Feb 23, 2018

@RocketChat/core

Before

The video call accept dialog is broken :

  • The title shows HTML
  • No support for i18n

capture d ecran 2018-02-23 a 17 21 30

After

capture d ecran 2018-02-23 a 17 17 26

@imanebahiaoui
Copy link

👍

@rodrigok rodrigok changed the title [FIX] Fix broken video call accept dialog [FIX] Broken video call accept dialog Mar 26, 2018
@rodrigok rodrigok added this to the 0.63.0 milestone Mar 26, 2018
@rodrigok rodrigok merged commit 79db195 into RocketChat:develop Mar 26, 2018
@rodrigok rodrigok mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo Awaiting requested review from ggazzo

@gdelavald gdelavald Awaiting requested review from gdelavald

1 more reviewer

@karlprieb karlprieb karlprieb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.63.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ramrami @imanebahiaoui @karlprieb @rodrigok @graywolf336