Skip to content

[FIX] Apostrophe-containing URL misparsed #9739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2018
Merged

[FIX] Apostrophe-containing URL misparsed #9739

merged 1 commit into from
Mar 26, 2018

Conversation

lunaticmonk
Copy link
Contributor

@lunaticmonk lunaticmonk commented Feb 16, 2018 •
edited by rodrigok
Loading

@RocketChat/core

Closes #9485
Closes #9976

Earlier when we tried to send the url like https://foo.com/t='a'&s=1, it wasnt getting detected properly.
Now it gets detected correctly:
screen shot 2018-02-16 at 1 45 12 pm

@RocketChat RocketChat deleted a comment Feb 16, 2018
@RocketChat RocketChat deleted a comment Feb 16, 2018
@RocketChat RocketChat deleted a comment Feb 16, 2018
@RocketChat RocketChat deleted a comment Feb 16, 2018
@RocketChat RocketChat deleted a comment Feb 16, 2018
@RocketChat RocketChat deleted a comment Feb 16, 2018
@RocketChat RocketChat deleted a comment Feb 16, 2018
@RocketChat RocketChat deleted a comment Feb 16, 2018
@RocketChat RocketChat deleted a comment Feb 16, 2018
@geekgonecrazy geekgonecrazy changed the title [BUG]: Fix the url detection issue [FIX]: Fix the url detection issue Feb 16, 2018
@geekgonecrazy geekgonecrazy changed the title [FIX]: Fix the url detection issue [FIX] Fix the url detection issue Feb 16, 2018
@RocketChat RocketChat deleted a comment Feb 19, 2018
@lunaticmonk
Copy link
Contributor Author

@sampaiodiego @rafaelks Please review.

@lunaticmonk lunaticmonk force-pushed the url-detection branch 3 times, most recently from 226ee2a to 6923a6d Compare February 24, 2018 04:44
@lunaticmonk
Copy link
Contributor Author

@geekgonecrazy @karlprieb please review.

@lunaticmonk lunaticmonk mentioned this pull request Mar 7, 2018
Closed
@aboyton
Copy link

aboyton commented Mar 25, 2018

Bump on getting this reviewed? Anything I can do to help?

@rodrigok rodrigok added this to the 0.63.0 milestone Mar 26, 2018
@rodrigok rodrigok changed the title [FIX] Fix the url detection issue [FIX] Apostrophe-containing URL misparsed Mar 26, 2018
@rodrigok rodrigok merged commit 48a6216 into RocketChat:develop Mar 26, 2018
@sampaiodiego
Copy link
Member

this is breaking messages inside an element, for example: _oops_ .. this will render to <em>oops</em> and htmlDecode will return empty string

@sampaiodiego sampaiodiego mentioned this pull request Mar 27, 2018
Merged
@rodrigok rodrigok mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@karlprieb karlprieb karlprieb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.63.0
Development

Successfully merging this pull request may close these issues.

Apostrophe-containing URL misparsed URL not detected properly
6 participants
@lunaticmonk @aboyton @sampaiodiego @karlprieb @rodrigok @graywolf336