@RicoSuter This is a breaking change, and it is implemented incorrectly as well.

With this change, the nswag generator changes the way it generated a C# client from a swagger doc. I have endpoints with query parameters that are arrays, and before this change they would correctly generate as ?myArray=val1&myArray=val2&myArray=val3, but now they generate as ?myArray=val1,val2,val3. Per the documentation, "When style is form, the default value is true. For all other styles, the default value is false." If you then read on the Style property, the docs say "Default values (based on value of in): for query - form; for path - simple; for header - simple; for cookie - form.", so, for query parameters the default style is form, which means the default value of explode should be true, as it was before, but with this PR merged in that has changed such that the default value is now false, breaking existing frameworks that use nswag for client library generation. Please have someone fix this breaking change so that query parameters work as they should per the documentation.

cc: @lahma

Please have someone fix this breaking change so that query parameters work as they should per the documentation.

@KirkMunroSagent can you be the one? A PR with new test coverage showing the desired way of working.

Please have someone fix this breaking change so that query parameters work as they should per the documentation.

@KirkMunroSagent can you be the one? A PR with new test coverage showing the desired way of working.

I'm on vacation, so there's no likelihood that I'll have time for this anytime soon.

This PR is a breaking change and should be reverted. It goes against the documentation, so the simplest way to fix this issue that didn't exist before is to create another PR that reverts this set of changes and then leave it until someone can re-do them properly while respecting the documentation.

we also ran into this issue.
current version of nswag (14.4.0.0) is not generating correct c# code for array parameters.

Same here. The current version 14.4.0 is not generating correct c# code for array parameters.

Hello,
I am experiencing the same error. Is a fix supposed to be released any time soon?

Thanks

Hello,
I am experiencing the same error. Is a fix supposed to be released any time soon?

Thanks