Skip to content

Fix for #3414 - C# generated client using FormUrlEncodedContent instead of StringContent #5029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

ErikApption
Copy link
Contributor

This is a fix for #3414. When "x-www-form-urlencoded" is accepted, NSwag will generate an invalid client that sends url encoded form as "application/json". This change checks if "application/json" is accepted and will prioritize it.

  • renamed ConsumesFormUrlEncoded to ConsumesOnlyFormUrlEncoded in liquid templates
  • ConsumesOnlyFormUrlEncoded will be set to false if json is accepted

…uid templates

- ConsumesOnlyFormUrlEncoded will be set to false if json is accepted
@ErikApption
Copy link
Contributor Author

@RicoSuter anything I can do to help with this PR? without this, NSwag generates invalid clients

@RicoSuter RicoSuter merged commit 71ae244 into RicoSuter:master Mar 29, 2025
3 checks passed
@RicoSuter
Copy link
Owner

Thanks for the PR.
Hopefully this does not break anyone..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants