Skip to content

Support configuring whether constructor parameter are sorted #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 27, 2025
Merged

Support configuring whether constructor parameter are sorted #1399

merged 5 commits into from
Jul 27, 2025

Conversation

manfred-brands
Copy link
Contributor

Replaces #1055

@manfred-brands manfred-brands mentioned this pull request Aug 6, 2021
Closed
@RicoSuter
Copy link
Owner

We should switch this to use public required string Foo { get; init; }, no?

@lahma lahma force-pushed the UnsortedConstructorParameters branch from 933acc6 to 0b434df Compare July 27, 2025 09:02
@lahma lahma force-pushed the UnsortedConstructorParameters branch from 95b8409 to d4811e1 Compare July 27, 2025 09:13
@lahma lahma changed the title Unsorted constructor parameters Support configuring whether constructor parameter are sorted Jul 27, 2025
lahma
lahma approved these changes Jul 27, 2025
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased this, tested and cases seem to work as expected. There was already some work done for init etc support so removed the extras, but the PR's main goal of correctly sorted/unsorted properties is fulfilled.

@lahma lahma merged commit 449c6d9 into RicoSuter:master Jul 27, 2025
2 checks passed
This was referenced Jul 30, 2025
Merged
Merged
Merged
Merged
@dependabot dependabot bot mentioned this pull request Aug 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
state: await-response state: conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manfred-brands @RicoSuter @lahma