Skip to content

fix ApplyRangeAttribute failing when min/max is specified as string #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2025
Merged

fix ApplyRangeAttribute failing when min/max is specified as string #1831

merged 1 commit into from
Jun 15, 2025

Conversation

sindrekroknes
Copy link
Contributor

For cultures not using '.' as the decimal separator, JsonSchemaGenerator.ApplyRangeAttribute fails for Range attributes like this

[Range(typeof(decimal), "5.5", "10.5")]
public double Decimal { get; set; }

This PR fixes that by using InvariantCulture

lahma
lahma approved these changes Jun 15, 2025
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@lahma lahma merged commit d8da9d6 into RicoSuter:master Jun 15, 2025
2 checks passed
This was referenced Jul 30, 2025
Merged
Merged
Merged
Merged
@dependabot dependabot bot mentioned this pull request Aug 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sindrekroknes @lahma