Skip to content

Cache NJsonSchema properties in JsonReferenceResolver #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

Cache NJsonSchema properties in JsonReferenceResolver #1817

merged 1 commit into from
May 1, 2025

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented May 1, 2025

There's high reflection cost the code path usually always hits JsonSchema type.

Using my custom large (1,3MB) swagger file.

Before

Method Mean Error StdDev Gen0 Gen1 Allocated
GenerateFile 151.2 ms 2.92 ms 7.22 ms 6000.0000 3000.0000 78.63 MB

After

Method Mean Error StdDev Gen0 Gen1 Gen2 Allocated
GenerateFile 112.0 ms 2.12 ms 4.56 ms 7000.0000 3000.0000 500.0000 78.27 MB

@lahma lahma merged commit 1099d74 into RicoSuter:master May 1, 2025
2 checks passed
@lahma lahma deleted the optimize-njsonschema-property-check branch May 1, 2025 06:20
This was referenced Jul 30, 2025
Merged
Merged
Merged
Merged
@dependabot dependabot bot mentioned this pull request Aug 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lahma