C# generator: create anoymous types with camel casing (reworked) #1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. |
|
@RicoSuter I know, a test would be appropriate But I ran into this issue when consuming a closed source api description, and I don't have enough OpenApi knowledge to build a sample file myself. |
|
doesnt seem to work correctly... Seems that i need to revert. |
|
@RicoSuter According to your diff screenshot, the right side of the code is the expected behaviour, as it eliminates the lower case class names. Or did I have a misunderstanding? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second attempt to fix RicoSuter/NSwag#4849 and RicoSuter/NSwag#4837 and a followup for #1716: since NSwag 14, the resulting C# file generated from a yaml file might contain lower case class names.
This seems to happen if an array item has as lower case type name hint (e.g. "data"), and a class "Data" was already generated.
In this situation,
DefaultTypeNameGenerator.GenerateAnonymousTypeNamedoes not callConversionUtilities.ConvertToUpperCamelCaseand thus picks the lower case class name "data" as "not used".With my fix, it would generate a class "Data2" again.
The first fix worked locally for me because I had one additional line that I forget to add to my pull request. This request adds this line and removes an unneccesary
ConvertToUpperCamelCasefrom the previous pull request (variabletypeNameHintis already camel cased now).Sorry for the confusion, I had some problems building/running NSwag/NJsonSchema and first added workaround code to my local NSwag copy, then applied it to NJsonSchema, where I lost one important line. But this time I really tested a fixed "NJsonSchema.dll" with NSwag console and can confirm that the generated cs file is valid ;-).