Devx improvements #78
Conversation
README.md
Outdated
| ## Contributing | ||
|
|
||
| If you'd like to contribute to this package, developing locally is simple. | ||
|
|
||
| 1. Run `yarn` from the root of this package | ||
| 2. Start the live reloader for the package `cd packages/relay-nextjs && yarn build-w` | ||
| 3. In a separate terminal strt the example app: `cd example && yarn dev` | ||
|
|
||
| Now, when you make any changes in `packages/relay-nextjs`, they will instantly be reflected in the example app. |
There was a problem hiding this comment.
This is an awesome change! Thank you very much for the improvements here, it's not something I've spent a ton of time on as this repo is synced in and out of the Revere monorepo whenever changes are made. Can we add a note of which yarn version is required?
There was a problem hiding this comment.
This is an awesome change! Thank you very much for the improvements here, it's not something I've spent a ton of time on as this repo is synced in and out of the Revere monorepo whenever changes are made.
No worries, happy to help!
Can we add a note of which yarn version is required?
Good call! Done.
There was a problem hiding this comment.
@rrdelaney Anything else needed here btw?
There was a problem hiding this comment.
Not at all! This PR is great, I just need to check it out locally and give it a whirl. Unfortunately I've been quite sick the past week so getting some time for that has been difficult. I will look soon though, no action need on your end, and thank you again for this wonderful effort.
There was a problem hiding this comment.
Right on, hope you feel better soon 🤙🏻
c97c844 to
8513401
Compare
This reverts commit 986888e.
Improved DevX with Yarn Workspaces
examplepackage can importrelay-nextjsdirectlyrelay-nextjs(dev only)Contributing
If you'd like to contribute to this package, developing locally is now as simple as:
yarnfrom the root of this packagecd packages/relay-nextjs && yarn build-wcd example && yarn devNow, when you make any changes in
packages/relay-nextjs, they will instantly be reflected in the example app.