Skip to content

Support async getClientInitialProps w backwards compabitible typing #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2022
Merged

Support async getClientInitialProps w backwards compabitible typing #77

merged 1 commit into from
Nov 29, 2022

Conversation

GioLogist
Copy link
Contributor

Fixes #70

We noticed that WiredComponent.getInitialProps is sync on client and async on server. We would be interested in them being async on either or, since it's technically allowed in Next.JS

As requested, also added backwards compatible typing, so sync and async will continue to work without issue.

rrdelaney
rrdelaney approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@rrdelaney rrdelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! Will release as v1.0.1 soon.

@rrdelaney rrdelaney merged commit 09b7f53 into RevereCRE:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rrdelaney rrdelaney rrdelaney approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WiredComponent.getInitialProps -> Always async
2 participants
@GioLogist @rrdelaney