Skip to content

Conversation

fire-at-will
Copy link
Contributor

@fire-at-will fire-at-will commented Jul 16, 2025

Description

This PR fixes the VirtualCurrencyBalancesScreen preview for Catalyst (Optimized For Mac). We were previously wrapping the previews in a NavigationStack to show the navigation title in the previews, but on Catalyst (Optimized For Mac), this displayed the view in a sidebar. This PR fixes that issue by instead wrapping the VirtualCurrencyBalancesScreen in a CompatibilityNavigationStack, which doesn't use the sidebar on Catalyst (Optimized For Mac).

I've tested this in a Catalyst (Optimized For Mac) app, and the screen looks just fine, so this issue only affected the previews.

Screenshots

Before

before

After

new

@fire-at-will fire-at-will self-assigned this Jul 16, 2025
Copy link

emerge-tools bot commented Jul 16, 2025

📸 Snapshot Test

6 modified, 699 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
RevenueCat
com.revenuecat.PaywallsTester
0 0 0 0 235 0 N/A
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad
0 0 3 0 232 0 ✅ Approved
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac
0 0 3 0 232 0 ✅ Approved

🛸 Powered by Emerge Tools

@fire-at-will fire-at-will marked this pull request as ready for review July 16, 2025 12:06
@fire-at-will fire-at-will merged commit 2992965 into main Jul 16, 2025
12 checks passed
@fire-at-will fire-at-will deleted the fix-vcbalancescreen-catalyst-preview branch July 16, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants