Add validation of Test Store API keys #5385
Conversation
| #if TEST_STORE | ||
| if apiKey.hasPrefix(testStoreKeyPrefix) { | ||
| // Test Store key format: "test_CtDdmbdWBySmqJeeQUTyrNxETUVkajsJ" | ||
| return .testStore | ||
| } | ||
| #endif // TEST_STORE |
There was a problem hiding this comment.
Having only this under the TEST_STORE flag is enough, since the APIKeyValidationResult enum is an internal API
📸 Snapshot Test1 modified, 704 unchanged
🛸 Powered by Emerge Tools |
| @@ -396,12 +404,14 @@ extension Configuration { | |||
| fileprivate static func verify(apiKey: String) { | |||
| switch self.validate(apiKey: apiKey) { | |||
| case .validApplePlatform: break | |||
| case .testStore: Logger.warn(Strings.configure.testStoreAPIKey) | |||
There was a problem hiding this comment.
I wasn't sure about this being a warning or just a debug log. I think making it a warning doesn't harm and serves as a constant reminder that the Test Store API key will eventually need to change. Lmk if you think otherwise!
| case .legacy: Logger.debug(Strings.configure.legacyAPIKey) | ||
| case .otherPlatforms: Logger.error(Strings.configure.invalidAPIKey) | ||
| } | ||
| } | ||
|
|
||
| private static let applePlatformKeyPrefixes: Set<String> = ["appl_", "mac_"] | ||
| private static let testStoreKeyPrefix = "test_" |
There was a problem hiding this comment.
I'm wondering should we make it a bit more explicit? Something like rc_test_? Not sure if we discussed this in the past though 😅
There was a problem hiding this comment.
Yeah, that's a very good point. I don't have a strong opinion in favor or against it, but, for sure, it's something that we can change anytime as long as we have the TEST_STORE compiler flag ON
This is the first PR of a series to add support for the Test Store in the SDK.
Checklist
purchases-androidand hybridsMotivation
The SDK has to identify API keys for the Test Store to modify its behavior accordingly
Description
Adds the validation of the Test Store API keys under the
TEST_STOREcompiler flag