Increase simulated renewal time in some StoreKit integration tests #5382
Conversation
|
@RCGitBot please test |
📸 Snapshot Test705 unchanged
🛸 Powered by Emerge Tools |
| // 'SKTestSession.TimeRate.monthlyRenewalEveryThirtySeconds' | ||
| // However, we've found that their behavior is not equivalent since using `monthlyRenewalEveryThirtySeconds` | ||
| // results in a crash in our tests. | ||
| testSession.timeRate = .init(rawValue: 6)! // == .oneSecondIsOneDay |
There was a problem hiding this comment.
Not a huge fan of this, but using .oneSecondIsOneDay directly creates a warning with a fix me button that changes it to .monthlyRenewalEveryThirtySeconds. And using .monthlyRenewalEveryThirtySeconds always results in a crash in my local machine.
I think this is acceptable since we are in unit tests and it is clearly (?) documented with comments.
Lmk if you think otherwise!
There was a problem hiding this comment.
could the rawValue change between versions of iOS?
There was a problem hiding this comment.
Great question. I don't think so, as it would mean breaking the API.
I wouldn't rely on this in the main code, but in unit tests I think it's fine (better this, with no warning and no fix me button that could lead to a crash.
For reference, this is the crash I'm getting locally when using .monthlyRenewalEveryThirtySeconds instead of . oneSecondIsOneDay.
https://forums.swift.org/t/sigabrt-freed-pointer-was-not-the-last-allocation-crash/78772
This reverts commit ece5003.
Motivation
We have some flaky StoreKit integration tests. This PR tries to make them less flaky.
Description
Some unit tests were randomly failing because the receipt posting would happen after the purchase expiration, which would cause the product entitlement become inactive.
This PR changes the
SKTestSession'stimeRateof some tests from.oneRenewalEveryTwoSecondsto.oneSecondIsOneDay. Because these affected tests simulate the purchase of a product with a 3-day trial, with this change, the first renewal time of the these tests changes from 2 seconds to 3 seconds, which should reduce their flakiness.