-
Notifications
You must be signed in to change notification settings - Fork 382
Add custom change plans support for customer center #5379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3 builds increased size
RevenueCat 1.0 (1)
|
Item | Install Size Change |
---|---|
DYLD.String Table | ⬆️ 73.8 kB |
Code Signature | ⬆️ 5.3 kB |
DYLD.Exports | ⬆️ 4.0 kB |
RevenueCatUI.CustomerCenterViewModel.CustomerCenterViewModel | ⬆️ 1.6 kB |
Other | ⬆️ 114.8 kB |
RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 200.0 kB (0.47%)
Total download size change: ⬆️ 48.3 kB (0.42%)
Largest size changes
Item | Install Size Change |
---|---|
DYLD.String Table | ⬆️ 74.9 kB |
Code Signature | ⬆️ 5.0 kB |
DYLD.Exports | ⬆️ 4.0 kB |
RevenueCatUI.CustomerCenterViewModel.CustomerCenterViewModel | ⬆️ 1.6 kB |
Other | ⬆️ 114.4 kB |
RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 200.0 kB (0.47%)
Total download size change: ⬆️ 48.3 kB (0.42%)
Largest size changes
Item | Install Size Change |
---|---|
DYLD.String Table | ⬆️ 74.9 kB |
Code Signature | ⬆️ 5.0 kB |
DYLD.Exports | ⬆️ 4.0 kB |
RevenueCatUI.CustomerCenterViewModel.CustomerCenterViewModel | ⬆️ 1.6 kB |
Other | ⬆️ 114.4 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
📸 Snapshot Test1 modified, 704 unchanged
🛸 Powered by Emerge Tools |
Tests/RevenueCatUITests/CustomerCenter/PurchaseInformationTests.swift
Outdated
Show resolved
Hide resolved
RevenueCatUI/CustomerCenter/ViewModels/PurchaseHistory/PurchaseHistoryViewModel.swift
Show resolved
Hide resolved
RevenueCatUI/CustomerCenter/ViewModels/CustomerCenterViewModel.swift
Outdated
Show resolved
Hide resolved
RevenueCatUI/CustomerCenter/ViewModels/BaseManageSubscriptionViewModel.swift
Outdated
Show resolved
Hide resolved
RevenueCatUI/CustomerCenter/Data/CustomerCenterConfigData+Mock.swift
Outdated
Show resolved
Hide resolved
func body(content: Content) -> some View { | ||
content | ||
.onPreferenceChange(ChangePlansSelectedPreferenceKey.self) { wrapperSubscriptionGroupID in | ||
if let subscriptionGroupID = wrapperSubscriptionGroupID?.value { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, but with the current code, I believe this can be an empty ""
string? https://github.com/RevenueCat/purchases-ios/pull/5379/files#diff-8182f46c9c24cf0ef51c67a65739033ca5c8205ac5498ebb192e6ed81cddc82fR185
c585a01
to
a8d29eb
Compare
ca0de24
to
a4a898d
Compare
RevenueCatUI/CustomerCenter/ViewModels/PurchaseHistory/PurchaseHistoryViewModel.swift
Outdated
Show resolved
Hide resolved
RevenueCatUI/CustomerCenter/ViewModels/PurchaseHistory/PurchaseHistoryViewModel.swift
Show resolved
Hide resolved
Co-authored-by: Cesar de la Vega <664544+vegaro@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just that changePlans
in plural in the CustomerCenterConfigData question
Motivation
Customer Center Change Plans allows developers to configure which subscription products from each subscription group should be available for customers to upgrade/downgrade to within the self-service customer center.
Description