Skip to content

Add a mechanism to test the presentIfNeeded API in the Paywalls tester. #5377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 17, 2025
Merged

Add a mechanism to test the presentIfNeeded API in the Paywalls tester. #5377

merged 5 commits into from
Jul 17, 2025

Conversation

clindsay3
Copy link
Collaborator

Motivation

I want to test the behavior of presenting a paywall via this API vs. using PaywallView directly, for the purposes of implementing paywalls on Mac.

Description

  • Adds a new option to the context menu on items in the Sandbox Paywalls tab to present the paywall using the presentIfNeeded API.

@clindsay3 clindsay3 requested review from joshdholtz and a team July 10, 2025 07:51
@emerge-tools Emerge Tools
Copy link

emerge-tools bot commented Jul 10, 2025 •
edited
Loading

📸 Snapshot Test

5 modified, 700 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad		 0 0 1 0 234 0 ✅ Approved
RevenueCat
com.revenuecat.PaywallsTester		 0 0 0 0 235 0 N/A
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac		 0 0 4 0 231 0 ✅ Approved

🛸 Powered by Emerge Tools

ajpallares
ajpallares approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition 👌 Thank you!

@clindsay3
Copy link
Collaborator Author

There were a few emerge snapshots unrelated to any of this work that had diffs -- seems just like flakiness, so I approved.

@clindsay3 clindsay3 merged commit 66f3f08 into main Jul 17, 2025
12 checks passed
@clindsay3 clindsay3 deleted the mac-paywalls/present-if-needed-testing branch July 17, 2025 08:02
@RCGitBot RCGitBot mentioned this pull request Jul 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpallares ajpallares ajpallares approved these changes

@joshdholtz joshdholtz Awaiting requested review from joshdholtz

Assignees
No one assigned
Labels
pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clindsay3 @ajpallares