Add build configurations for tuist workspace #5364
Conversation
Projects/PaywallTester/Project.swift
Outdated
| if FileManager.default.fileExists(atPath: "Local.xcconfig") { | ||
| additionalFiles.append(.glob(pattern: "../../Local.xcconfig")) | ||
| } |
There was a problem hiding this comment.
Maybe not for this PR, but would it be possible/make sense to have this be reused from the main Project.swift instead of repeated in every Project.swift file?
Maybe something similar to xcconfigFileConfigurations below. E.g. commonFiles.
There was a problem hiding this comment.
I think so, let me re-do this
There was a problem hiding this comment.
I'll tackle this in another PR, but I think that since we're adding those files to the workspace it should be ok if we remove them from each project.
Projects/PaywallTester/Project.swift
Outdated
| @@ -49,6 +47,9 @@ let project = Project( | |||
| sources: [ | |||
| "../../Tests/TestingApps/PaywallsTester/PaywallsTester/**/*.swift" | |||
| ], | |||
| resources: [ | |||
| additionalFiles.count == 2 ? "../../Local.xcconfig" : "" | |||
There was a problem hiding this comment.
This looks dangerous. And I don't really understand why this is needed? I don't think xcconfig files need to be added to the targets
There was a problem hiding this comment.
I've removed additionalFilesfrom the project definition. Now those are declared in the workspace.
| settings: .settings( | ||
| base: [:].automaticCodeSigning(devTeam: .revenueCatTeamID), | ||
| configurations: .xcconfigFileConfigurations, | ||
| defaultSettings: .essential | ||
| ), |
There was a problem hiding this comment.
this can probably be generalized even further (for another PR)
|
@RCGitBot please test |
| public static var xcconfigFileConfigurations: [Configuration] { | ||
| [ | ||
| .debug(name: "Debug", xcconfig: .relativeToRoot("Global.xcconfig")), | ||
| .release(name: "Release", xcconfig: .relativeToRoot("Global.xcconfig")), |
There was a problem hiding this comment.
I am not sure about this, I think it shouldn't point to the Global.xcconfig right @ajpallares ?
|
@RCGitBot please test |
| "REVENUECAT_API_KEY": "$(REVENUECAT_API_KEY)", | ||
| "REVENUECAT_PROXY_URL_SCHEME": "$(REVENUECAT_PROXY_URL_SCHEME)", | ||
| "REVENUECAT_PROXY_URL_HOST": "$(REVENUECAT_PROXY_URL_HOST)" |
There was a problem hiding this comment.
Question: wouldn't this be covered by the xcconfig?
There was a problem hiding this comment.
mmm good question, I'll try it out
There was a problem hiding this comment.
Just tested it out, and we need it. Otherwise it's not picked by the bundle
Motivation
While testing the maestro app I realized the xcconfig files were not being picked.
Description