Skip to content

Temporary revert of automatic health reporting in the SDK #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Temporary revert of automatic health reporting in the SDK #5353

merged 2 commits into from
Jul 3, 2025

Conversation

polpielladev
Copy link
Contributor

We have some failing BackEnd integration tests that are failing after we added this.

We also noticed some signature verification issues, so in the meantime let's revert this so that we can release.

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-android and hybrids

@polpielladev
Copy link
Contributor Author

@RCGitBot please test

@polpielladev polpielladev requested a review from ajpallares July 3, 2025 11:51
@emerge-tools Emerge Tools
Copy link

emerge-tools bot commented Jul 3, 2025

1 build decreased size

Name Version Download Change Install Change Approval
RevenueCat
com.revenuecat.PaywallsTester		 1.0 (1) 12.2 MB ⬇️ 37.1 kB (-0.3%) 46.8 MB ⬇️ 141.3 kB (-0.3%) N/A

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 141.3 kB (-0.3%)
Total download size change: ⬇️ 37.1 kB (-0.3%)

Largest size changes

Item Install Size Change
DYLD.String Table ⬇️ -53.0 kB
RevenueCat.Purchases.Purchases ⬆️ 9.1 kB
RCPurchases.Objc Metadata ⬇️ -6.8 kB
Code Signature ⬇️ -3.2 kB
DYLD.Exports ⬇️ -2.1 kB
View Treemap

Image of diff

🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@polpielladev polpielladev mentioned this pull request Jul 3, 2025
Closed
@polpielladev polpielladev merged commit dd7086f into main Jul 3, 2025
41 checks passed
@polpielladev polpielladev deleted the revert-health-sdk-changes branch July 3, 2025 12:22
polpielladev added a commit that referenced this pull request Jul 3, 2025
@polpielladev
Revert "Temporary revert of automatic health reporting in the SDK (#5353
f011c8c 
)"

This reverts commit dd7086f.
@RCGitBot RCGitBot mentioned this pull request Jul 3, 2025
Merged
polpielladev added a commit that referenced this pull request Jul 7, 2025
@polpielladev
Revert "Temporary revert of automatic health reporting in the SDK (#5353
00e72a8 
)"

This reverts commit dd7086f.
polpielladev added a commit that referenced this pull request Jul 7, 2025
@polpielladev
[DX-457] Re-apply Health SDK logging on app launch (#5360)
39ad551 
* Revert "Temporary revert of automatic health reporting in the SDK (#5353)"

This reverts commit dd7086f.

* Do not run health check when running integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpallares ajpallares ajpallares approved these changes

Assignees
No one assigned
Labels
pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polpielladev @ajpallares