-
Notifications
You must be signed in to change notification settings - Fork 382
Add _spi(Internal) to Customer Center #5270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through all the files and didnt' see anything to call out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! This will result in a much cleaner public API for developers! 🎉
And thank you for taking over as the official spi
guy 😄
Before approving, I have some comments and a question: are all the @_spi(Internal) import
s in RevenueCatUI actually needed?
RevenueCatUI/CustomerCenter/Data/CustomerCenterConfigData+Mock.swift
Outdated
Show resolved
Hide resolved
Tests/RevenueCatUITests/CustomerCenter/BaseManageSubscriptionViewModelTests.swift
Show resolved
Hide resolved
* Add _spi(Internal) to costumer center * add missing spi * Add _spi(Internal) to costumer center * add extra spi * missing spi * missing spi * add missing spi
* refactor history view * tests * update hash * donbe * lint * lint * mocks * redo mocks * fixed tests * mocks * delete yearly * purchase hist * fixed snap * delete extra intialiser parameter * Renamed isActive to isExpired (#5261) * Add badge cancelled trial to PurchaseCardView (#5262) * Renamed isActive to isExpired * Add badge cancelled trial * missing default key * missing default key * isExpired * Version bump for 5.28.1 (#5271) * Preparing for next version (#5272) * Add _spi(Internal) to Customer Center (#5270) * Add _spi(Internal) to costumer center * add missing spi * Add _spi(Internal) to costumer center * add extra spi * missing spi * missing spi * add missing spi * fix bad merge * Update Sources/CustomerCenter/CustomerCenterConfigData.swift * Add abbrev to Gemfile (#5207) * Delete duplicate OfferingsList.swift from PaywallTester (#5249) * removed * using customer info * added exp date and renewal date * added exp date and renewal date --------- Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
* refactor history view * tests * update hash * donbe * lint * lint * mocks * redo mocks * fixed tests * mocks * delete yearly * purchase hist * fixed snap * delete extra intialiser parameter * Renamed isActive to isExpired (#5261) * Add badge cancelled trial to PurchaseCardView (#5262) * Renamed isActive to isExpired * Add badge cancelled trial * missing default key * missing default key * isExpired * testing promo * Version bump for 5.28.1 (#5271) * Preparing for next version (#5272) * Add _spi(Internal) to Customer Center (#5270) * Add _spi(Internal) to costumer center * add missing spi * Add _spi(Internal) to costumer center * add extra spi * missing spi * missing spi * add missing spi * added tests * added test * fix bad merge * trailing comma --------- Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
* refactor history view * tests * update hash * donbe * lint * lint * mocks * redo mocks * fixed tests * mocks * delete yearly * purchase hist * fixed snap * delete extra intialiser parameter * Renamed isActive to isExpired (#5261) * Add badge cancelled trial to PurchaseCardView (#5262) * Renamed isActive to isExpired * Add badge cancelled trial * missing default key * missing default key * isExpired * Version bump for 5.28.1 (#5271) * Preparing for next version (#5272) * Add _spi(Internal) to Customer Center (#5270) * Add _spi(Internal) to costumer center * add missing spi * Add _spi(Internal) to costumer center * add extra spi * missing spi * missing spi * add missing spi * fix bad merge * Use new store promotional key * Update Sources/CustomerCenter/CustomerCenterConfigData.swift --------- Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
Motivation
We want to add
spi
to currentlypublic
entities that shouldn't be public.Description
spi
to existing entities