Skip to content

Conversation

facumenzella
Copy link
Contributor

Motivation

We want to add spi to currently public entities that shouldn't be public.

Description

  • Add missing spi to existing entities

@facumenzella facumenzella requested review from vegaro, ajpallares and a team June 11, 2025 15:52
Copy link
Contributor

@vegaro vegaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all the files and didnt' see anything to call out

Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! This will result in a much cleaner public API for developers! 🎉
And thank you for taking over as the official spi guy 😄

Before approving, I have some comments and a question: are all the @_spi(Internal) imports in RevenueCatUI actually needed?

@facumenzella facumenzella enabled auto-merge (squash) June 12, 2025 08:31
@facumenzella facumenzella merged commit 7e9cb18 into main Jun 12, 2025
12 checks passed
@facumenzella facumenzella deleted the other/add_spi_customer_center branch June 12, 2025 08:38
facumenzella added a commit that referenced this pull request Jun 12, 2025
* Add _spi(Internal) to costumer center

* add missing spi

* Add _spi(Internal) to costumer center

* add extra spi

* missing spi

* missing spi

* add missing spi
facumenzella added a commit that referenced this pull request Jun 13, 2025
* refactor history view

* tests

* update hash

* donbe

* lint

* lint

* mocks

* redo mocks

* fixed tests

* mocks

* delete yearly

* purchase hist

* fixed snap

* delete extra intialiser parameter

* Renamed isActive to isExpired (#5261)

* Add badge cancelled trial to PurchaseCardView (#5262)

* Renamed isActive to isExpired

* Add badge cancelled trial

* missing default key

* missing default key

* isExpired

* Version bump for 5.28.1 (#5271)

* Preparing for next version (#5272)

* Add _spi(Internal) to Customer Center (#5270)

* Add _spi(Internal) to costumer center

* add missing spi

* Add _spi(Internal) to costumer center

* add extra spi

* missing spi

* missing spi

* add missing spi

* fix bad merge

* Update Sources/CustomerCenter/CustomerCenterConfigData.swift

* Add abbrev to Gemfile (#5207)

* Delete duplicate OfferingsList.swift from PaywallTester (#5249)

* removed

* using customer info

* added exp date and renewal date

* added exp date and renewal date

---------

Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
facumenzella added a commit that referenced this pull request Jun 13, 2025
* refactor history view

* tests

* update hash

* donbe

* lint

* lint

* mocks

* redo mocks

* fixed tests

* mocks

* delete yearly

* purchase hist

* fixed snap

* delete extra intialiser parameter

* Renamed isActive to isExpired (#5261)

* Add badge cancelled trial to PurchaseCardView (#5262)

* Renamed isActive to isExpired

* Add badge cancelled trial

* missing default key

* missing default key

* isExpired

* testing promo

* Version bump for 5.28.1 (#5271)

* Preparing for next version (#5272)

* Add _spi(Internal) to Customer Center (#5270)

* Add _spi(Internal) to costumer center

* add missing spi

* Add _spi(Internal) to costumer center

* add extra spi

* missing spi

* missing spi

* add missing spi

* added tests

* added test

* fix bad merge

* trailing comma

---------

Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
facumenzella added a commit that referenced this pull request Jun 17, 2025
* refactor history view

* tests

* update hash

* donbe

* lint

* lint

* mocks

* redo mocks

* fixed tests

* mocks

* delete yearly

* purchase hist

* fixed snap

* delete extra intialiser parameter

* Renamed isActive to isExpired (#5261)

* Add badge cancelled trial to PurchaseCardView (#5262)

* Renamed isActive to isExpired

* Add badge cancelled trial

* missing default key

* missing default key

* isExpired

* Version bump for 5.28.1 (#5271)

* Preparing for next version (#5272)

* Add _spi(Internal) to Customer Center (#5270)

* Add _spi(Internal) to costumer center

* add missing spi

* Add _spi(Internal) to costumer center

* add extra spi

* missing spi

* missing spi

* add missing spi

* fix bad merge

* Use new store promotional key

* Update Sources/CustomerCenter/CustomerCenterConfigData.swift

---------

Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants